expression:implement vectorized evaluation for builtinExtractDurationSig #13489

icditwang · 2019-11-15T06:58:00Z

What problem does this PR solve?

implement vectorized evaluation for builtinExtractDurationSig

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc-8         	   27074	     45984 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc-8      	   17084	     70361 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#01-8      	   29985	     40106 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#01-8   	   17856	     67603 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#02-8      	   32161	     38366 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#02-8   	   18800	     66002 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#03-8      	   41064	     30228 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#03-8   	   21272	     53396 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#04-8      	   17841	     66772 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#04-8   	   12922	    123070 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#05-8      	   16162	     72750 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#05-8   	   12325	     98556 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#06-8      	   22459	     53246 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#06-8   	   15184	     78811 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#07-8      	   20792	     57100 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#07-8   	   12308	     91380 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#08-8      	   25328	     48678 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#08-8   	   13377	     99765 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-VecBuiltinFunc#09-8      	   24108	     48568 ns/op	       8 B/op	       1 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinExtractDurationSig-NonVecBuiltinFunc#09-8   	   16314	     72280 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

Unit test

sre-bot · 2019-11-15T06:58:04Z

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

expression/builtin_time_vec.go

expression/builtin_time_vec_test.go

codecov · 2019-11-20T11:24:52Z

Codecov Report

❗ No coverage uploaded for pull request base (master@f1c4011). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13489   +/-   ##
===========================================
  Coverage          ?   80.3859%           
===========================================
  Files             ?        474           
  Lines             ?     117941           
  Branches          ?          0           
===========================================
  Hits              ?      94808           
  Misses            ?      15706           
  Partials          ?       7427

qw4990 · 2019-11-21T02:41:18Z

expression/builtin_time_vec.go

+		}
+		unitI := unit.GetString(i)
+		duration.Duration = durIs[i]
+		duration.Fsp = int8(types.UnspecifiedFsp)


It should be b.args[1].GetType().Decimal.

I noticed that while I use gofmt command,the ast.Now's test case changed its style.Is it ok?

sre-bot · 2019-11-28T02:49:49Z

@icditwang, please update your pull request.

icditwang · 2019-12-02T07:33:35Z

@qw4990 Anything need change in this pr?

sre-bot · 2019-12-09T07:27:07Z

@icditwang, please update your pull request.

sre-bot · 2019-12-16T07:27:11Z

@icditwang, please update your pull request.

SunRunAway · 2019-12-18T06:19:48Z

expression/builtin_time_vec.go

+		}
+		unitI := unit.GetString(i)
+		duration.Duration = durIs[i]
+		duration.Fsp = int8(b.args[1].GetType().Decimal)


We can cache the result of int8(b.args[1].GetType().Decimal) outside the for loop.

expression/builtin_time_vec_test.go

qw4990

LGTM, please address SunRunAway's comments.

SunRunAway

LGTM

sre-bot · 2019-12-19T12:56:18Z

/run-all-tests

sre-bot · 2019-12-19T12:58:23Z

@icditwang merge failed.

qw4990 · 2019-12-20T07:34:36Z

/run-integration-copr-test

sre-bot · 2019-12-20T07:42:51Z

@icditwang complete task #12103 and get 50 score, currerent score 500.

sre-bot · 2019-12-20T07:42:53Z

Congratulations, you get 500 score from easy level tasks in PCP-S1, and if your PRs in reviewed stage all got merged, the score will be 650, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

…Sig (pingcap#13489)

icditwang requested a review from a team as a code owner November 15, 2019 06:58

sre-bot added the contribution This PR is from a community contributor. label Nov 15, 2019

ghost requested review from SunRunAway and wshwsh12 and removed request for a team November 15, 2019 06:58

SunRunAway reviewed Nov 15, 2019

View reviewed changes

expression/builtin_time_vec.go Outdated Show resolved Hide resolved

zz-jason added the component/expression label Nov 15, 2019

wshwsh12 reviewed Nov 17, 2019

View reviewed changes

expression/builtin_time_vec_test.go Outdated Show resolved Hide resolved

qw4990 added the status/ReqChange label Nov 19, 2019

icditwang added 3 commits November 20, 2019 17:33

expression:implement vectorized evaluation for builtinExtractDurationSig

8961f5c

Merge branch 'real-master'

5e6466f

fix bug

e393d76

icditwang force-pushed the builtinExtractDurationSig branch from cb5dc86 to e393d76 Compare November 20, 2019 10:33

icditwang added 3 commits November 20, 2019 18:34

remove some code

7e552a3

fix bug

7a91f3f

resolve check_dev

6cf751f

resolve check_dev

8bd7a7d

qw4990 reviewed Nov 21, 2019

View reviewed changes

change fsp

9261e1e

icditwang added 3 commits November 28, 2019 11:02

Merge branch 'master' of https://github.com/icditwang/tidb

8255008

recolve the repeate of ast.Extract

4cc4aae

Merge https://github.com/pingcap/tidb

57c3d02

icditwang force-pushed the builtinExtractDurationSig branch from f9f7726 to 57c3d02 Compare November 28, 2019 03:12

SunRunAway self-requested a review December 18, 2019 05:53

SunRunAway requested review from qw4990 and wshwsh12 December 18, 2019 05:53

SunRunAway reviewed Dec 18, 2019

View reviewed changes

Merge branch 'real-master'

a4be5e0

qw4990 reviewed Dec 18, 2019

View reviewed changes

qw4990 added status/LGT1 Indicates that a PR has LGTM 1. and removed status/ReqChange labels Dec 18, 2019

add test cases

31870f2

icditwang force-pushed the builtinExtractDurationSig branch from fdd80dd to 31870f2 Compare December 18, 2019 12:22

icditwang requested a review from SunRunAway December 18, 2019 12:27

SunRunAway approved these changes Dec 19, 2019

View reviewed changes

SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Dec 19, 2019

Merge branch 'master' into builtinExtractDurationSig

f1c4011

SunRunAway removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2019

qw4990 added the status/all tests passed label Dec 20, 2019

Merge branch 'master' into builtinExtractDurationSig

15c96f9

qw4990 merged commit 3368645 into pingcap:master Dec 20, 2019

qw4990 mentioned this pull request Dec 20, 2019

expression: implement vectorized evaluation for builtinExtractDurationSig #14139

Closed

icditwang deleted the builtinExtractDurationSig branch December 20, 2019 10:09

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019

expression:implement vectorized evaluation for builtinExtractDuration…

2a1ea0f

…Sig (pingcap#13489)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expression:implement vectorized evaluation for builtinExtractDurationSig #13489

expression:implement vectorized evaluation for builtinExtractDurationSig #13489

icditwang commented Nov 15, 2019 •

edited

Loading

sre-bot commented Nov 15, 2019

codecov bot commented Nov 20, 2019 •

edited

Loading

qw4990 Nov 21, 2019

icditwang Nov 21, 2019

icditwang Nov 21, 2019

sre-bot commented Nov 28, 2019

icditwang commented Dec 2, 2019

sre-bot commented Dec 9, 2019

sre-bot commented Dec 16, 2019

SunRunAway Dec 18, 2019

qw4990 left a comment

SunRunAway left a comment

sre-bot commented Dec 19, 2019

sre-bot commented Dec 19, 2019

qw4990 commented Dec 20, 2019

sre-bot commented Dec 20, 2019

sre-bot commented Dec 20, 2019

expression:implement vectorized evaluation for builtinExtractDurationSig #13489

expression:implement vectorized evaluation for builtinExtractDurationSig #13489

Conversation

icditwang commented Nov 15, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

sre-bot commented Nov 15, 2019

codecov bot commented Nov 20, 2019 • edited Loading

Codecov Report

qw4990 Nov 21, 2019

Choose a reason for hiding this comment

icditwang Nov 21, 2019

Choose a reason for hiding this comment

icditwang Nov 21, 2019

Choose a reason for hiding this comment

sre-bot commented Nov 28, 2019

icditwang commented Dec 2, 2019

sre-bot commented Dec 9, 2019

sre-bot commented Dec 16, 2019

SunRunAway Dec 18, 2019

Choose a reason for hiding this comment

qw4990 left a comment

Choose a reason for hiding this comment

SunRunAway left a comment

Choose a reason for hiding this comment

sre-bot commented Dec 19, 2019

sre-bot commented Dec 19, 2019

qw4990 commented Dec 20, 2019

sre-bot commented Dec 20, 2019

sre-bot commented Dec 20, 2019

icditwang commented Nov 15, 2019 •

edited

Loading

codecov bot commented Nov 20, 2019 •

edited

Loading