*: tidy code && prealloc some slice for performance #13468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiekeyi98
commented
Nov 14, 2019
cmd/explaintest/main.go
Outdated
| @@ -140,11 +140,11 @@ LOOP: | |||
| break LOOP | |||
| default: | |||
| if strings.HasPrefix(s, "--error") { | |||
| t.expectedErrs = strings.Split(strings.TrimSpace(strings.TrimLeft(s, "--error")), ",") | |||
There was a problem hiding this comment.
// TrimLeft returns a slice of the string s with all leading
// Unicode code points contained in cutset removed.
//
// To remove a prefix, use TrimPrefix instead.
As the context (HasPrefix) , I think we should use TrimPrefix
ddl/db_test.go
Outdated
| @@ -3606,7 +3606,7 @@ func (s *testDBSuite2) TestTablesLockDelayClean(c *C) { | |||
| tk.Se.Close() | |||
| wg.Done() | |||
| }() | |||
| time.Sleep(50) | |||
| time.Sleep(50 * time.Nanosecond) | |||
There was a problem hiding this comment.
time.Sleep(50) is puzzled, we should add the unit.
| @@ -225,7 +225,7 @@ func TestSyncerSimple(t *testing.T) { | |||
| } | |||
|
|
|||
| func isTimeoutError(err error) bool { | |||
| if terror.ErrorEqual(err, goctx.DeadlineExceeded) || grpc.Code(errors.Cause(err)) == codes.DeadlineExceeded || | |||
| if terror.ErrorEqual(err, goctx.DeadlineExceeded) || status.Code(errors.Cause(err)) == codes.DeadlineExceeded || | |||
There was a problem hiding this comment.
Code returns the error code for err if it was produced by the rpc system. Otherwise, it returns codes.Unknown.
Deprecated: use status.Code instead.
Codecov Report
@@ Coverage Diff @@
## master #13468 +/- ##
===========================================
Coverage ? 80.0788%
===========================================
Files ? 473
Lines ? 116620
Branches ? 0
===========================================
Hits ? 93388
Misses ? 15888
Partials ? 7344 |
zz-jason
reviewed
Dec 28, 2019
|
BTW, this PR is conflicted with the master branch, please resolve the conflicts in your spare time. |
ghost
requested review from
eurekaka and
francis0407
and removed request for
a team
zz-jason
added
status/LGT1
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Tests
This change is