expression:implement vectorized evaluation for builtinInstrBinarySig #13446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
ghost
requested review from
qw4990 and
wshwsh12
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13446 +/- ##
===========================================
Coverage 80.3866% 80.3866%
===========================================
Files 472 472
Lines 115100 115100
===========================================
Hits 92525 92525
Misses 15370 15370
Partials 7205 7205 |
|
@wshwsh12 I'm so sorry I delete your comment by accident.I have messaged you at the slack. |
b41sh
reviewed
Nov 15, 2019
expression/builtin_string_vec.go
Outdated
| substrI := substr.GetString(i) | ||
| idx := strings.Index(strI, substrI) | ||
| if idx == -1 { | ||
| res[i] = 0 |
There was a problem hiding this comment.
This state seems like equivalent to
res[i] = int64(idx + 1)
There was a problem hiding this comment.
I will remove it.Do I need to change the non-vec func?It has it also.
There was a problem hiding this comment.
I think we don't need change that one
icditwang
force-pushed
the
builtinInstrBinarySig
branch
from
6583ef1 to
b895335
Compare
|
LGTM |
qw4990
added
status/can-merge
|
/run-all-tests |
|
@icditwang merge failed. |
|
/run-integration-copr-test |
qw4990
approved these changes
Nov 16, 2019
|
@icditwang complete task #12103 and get 50 score, currerent score 100. |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCP #12103
What problem does this PR solve?
implement vectorized evaluation for builtinInstrBinarySig
What is changed and how it works?
Check List
Tests