Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Solve the problem that the parent query condition is pushed … #13231

Merged
merged 2 commits into from
Nov 11, 2019
Merged

planner: Solve the problem that the parent query condition is pushed … #13231

merged 2 commits into from
Nov 11, 2019

Conversation

lovewin99
Copy link
Contributor

cherry-pick #11624

@lovewin99
planner: Solve the problem that the parent query condition is pushed …
87f9780 
…incorrectly when the setvar function is evaluated in the subquery.(pingcap#11624)
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 7, 2019
@lovewin99
Copy link
Contributor Author

PTAL @cyliu0 @eurekaka @qw4990

zz-jason
zz-jason reviewed Nov 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2019
eurekaka
eurekaka approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13230, 13235

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4de6f3f into pingcap:release-3.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lovewin99 @sre-bot @zz-jason @eurekaka