Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/admin: support admin check table on partition table (#12796) #13143

Merged
merged 5 commits into from
Nov 6, 2019
Merged

util/admin: support admin check table on partition table (#12796) #13143

merged 5 commits into from
Nov 6, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

cherry pick cherry-pick #12796

both modified:   executor/admin_test.go
both modified:   planner/core/exhaust_physical_plans.go
both modified:   planner/core/find_best_task.go
both modified:   planner/core/planbuilder.go

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2019
zimulala
zimulala approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 6, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

Your auto merge job has been accepted, waiting for 13141

@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit da5d75c into pingcap:release-2.1 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @sre-bot @bb7133 @zimulala @zz-jason