Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastDecimalAsTimeSig #12904

Merged
merged 6 commits into from
Oct 25, 2019
Merged

expression: implement vectorized evaluation for builtinCastDecimalAsTimeSig #12904

merged 6 commits into from
Oct 25, 2019

Conversation

ekalinin
Copy link
Contributor

What problem does this PR solve?

This PR implements vectorized builtinCastDecimalAsTimeSig. See #12101

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Cast VB_FUNC=builtinCastDecimalAsTimeSig                        
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinCastFunc \
		-run=BenchmarkVectorizedBuiltinCastFunc \
		-args "builtinCastDecimalAsTimeSig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsTimeSig-VecBuiltinFunc-12         	     405	   2786994 ns/op	  545247 B/op	   16681 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDecimalAsTimeSig-NonVecBuiltinFunc-12      	     292	   3739374 ns/op	  545240 B/op	   16681 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	3.023s

Check List

Tests

  • Unit test
  • Integration test

@ekalinin ekalinin requested a review from a team as a code owner October 23, 2019 09:57
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 23, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 23, 2019 09:57
@codecov
Copy link

codecov bot commented Oct 23, 2019 •
edited
Loading

Codecov Report

Merging #12904 into master will increase coverage by 0.0931%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12904        +/-   ##
================================================
+ Coverage   79.9828%   80.0759%   +0.0931%     
================================================
  Files           465        465                
  Lines        107213     107649       +436     
================================================
+ Hits          85752      86201       +449     
+ Misses        14979      14967        -12     
+ Partials       6482       6481         -1

Reminiscent
Reminiscent reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 24, 2019
@zyxbest
Copy link

zyxbest commented Oct 24, 2019

/build

@zyxbest
Copy link

zyxbest commented Oct 24, 2019

please ignore the idc-jenkins-ci/build

wshwsh12
wshwsh12 reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LTGM

wshwsh12
wshwsh12 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 25, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1bbc313 into pingcap:master Oct 25, 2019
@ekalinin ekalinin deleted the vec-builtinCastDecimalAsTimeSig branch November 7, 2019 09:10
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinCastDecimalAsT…
9b6d96b 
…imeSig (pingcap#12904)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ekalinin @zyxbest @sre-bot @wshwsh12 @Reminiscent @bb7133