Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastIntAsTimeSig #12842

Merged
merged 20 commits into from
Oct 22, 2019
Merged

expression: implement vectorized evaluation for builtinCastIntAsTimeSig #12842

merged 20 commits into from
Oct 22, 2019

Conversation

ekalinin
Copy link
Contributor

@ekalinin ekalinin commented Oct 20, 2019 •
edited
Loading

What problem does this PR solve?

This PR implements vectorized builtinCastIntAsTimeSig. See #12101

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Cast VB_FUNC=builtinCastIntAsTimeSig
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinCastFunc \
		-run=BenchmarkVectorizedBuiltinCastFunc \
		-args "builtinCastIntAsTimeSig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinCastFunc/builtinCastIntAsTimeSig-VecBuiltinFunc-12         	     399	   2869949 ns/op	  351562 B/op	    5157 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastIntAsTimeSig-NonVecBuiltinFunc-12      	     298	   4429257 ns/op	  351563 B/op	    5157 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	3.229s

Check List

Tests

  • Unit test

@ekalinin ekalinin requested a review from a team as a code owner October 20, 2019 21:06
@ghost ghost requested review from SunRunAway and removed request for a team October 20, 2019 21:06
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 20, 2019
@qw4990 qw4990 self-requested a review October 21, 2019 05:43
@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #12842 into master will increase coverage by 0.1718%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #12842        +/-   ##
================================================
+ Coverage   79.9843%   80.1562%   +0.1719%     
================================================
  Files           465        465                
  Lines        107311     107525       +214     
================================================
+ Hits          85832      86188       +356     
+ Misses        15041      14912       -129     
+ Partials       6438       6425        -13

@qw4990
Copy link
Contributor

qw4990 commented Oct 22, 2019

/build

qw4990
qw4990 reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 requested a review from SunRunAway October 22, 2019 09:48
@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 22, 2019
Reminiscent
Reminiscent approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 8f6e034 into pingcap:master Oct 22, 2019
@ekalinin ekalinin deleted the vec-builtinCastIntAsTimeSig branch October 22, 2019 12:39
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinCastIntAsTimeS…
51e3ed5 
…ig (pingcap#12842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekalinin @qw4990 @sre-bot @SunRunAway @Reminiscent