Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add a column describing memory usage for table information_schema.processlist (#10837) #12801

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Oct 17, 2019

Automated cherry pick of #10837 on release-3.0.


What problem does this PR solve?

Closes #10199

What is changed and how it works?

Add a column describing memory usage for table information_schema.processlist and keep show processlist acting as before.

mysql> SELECT * FROM information_schema.processlist;
+------+------+-----------+------+---------+------+-------+----------------------------------------------+------+
| ID   | USER | HOST      | DB   | COMMAND | TIME | STATE | INFO                                         | MEM  |
+------+------+-----------+------+---------+------+-------+----------------------------------------------+------+
|    1 | root | 127.0.0.1 | test | Query   |    1 | 2     | select * from t, ta                          |  856 |
|    2 | root | 127.0.0.1 | test | Query   |    0 | 2     | SELECT * FROM information_schema.processlist |    0 |
+------+------+-----------+------+---------+------+-------+----------------------------------------------+------+
2 rows in set (0.00 sec)

mysql> show processlist;
+------+------+-----------+------+---------+------+-------+----------------------+
| Id   | User | Host      | db   | Command | Time | State | Info                 |
+------+------+-----------+------+---------+------+-------+----------------------+
|    2 | root | 127.0.0.1 | test | Query   |    0 | 2     | show processlist     |
|    1 | root | 127.0.0.1 | test | Query   |    1 | 2     | select *  from t, ta |
+------+------+-----------+------+---------+------+-------+----------------------+
2 rows in set (0.01 sec)

Check List

Tests

  • Unit test
  • Manual test (see above)

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation
  • Need to be included in the release note?

This change is Reviewable

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 18, 2019
@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

Your auto merge job has been accepted, waiting for 12733, 12807

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

@SunRunAway merge failed.

@SunRunAway
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Oct 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

@SunRunAway merge failed.

@SunRunAway SunRunAway added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Oct 18, 2019
@SunRunAway
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka merged commit b11578f into pingcap:release-3.0 Oct 18, 2019
@SunRunAway SunRunAway deleted the automated-cherry-pick-of-#10837-upstream-release-3.0 branch October 18, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants