Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix TestTLS when use RSA-PSS (#10274) #12572

Merged
merged 3 commits into from
Oct 10, 2019
Merged

server: fix TestTLS when use RSA-PSS (#10274) #12572

merged 3 commits into from
Oct 10, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Oct 9, 2019

Cherry-pick #10274 to v2.1

@zimulala
Copy link
Contributor Author

zimulala commented Oct 9, 2019

PTAL @lysu @jackysp

@zimulala zimulala requested a review from lysu October 9, 2019 07:45
@zimulala
Copy link
Contributor Author

zimulala commented Oct 9, 2019

/run-all-tests

lysu
lysu reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2019
@zimulala
Copy link
Contributor Author

zimulala commented Oct 9, 2019

/run-all-tests

jackysp
jackysp approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AilinKid
AilinKid reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao tiancaiamao mentioned this pull request Oct 10, 2019
Merged
@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 10, 2019

/run-all-tests

@sre-bot sre-bot merged commit a8f26cf into pingcap:release-2.1 Oct 10, 2019
@zimulala zimulala deleted the tls branch October 10, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@AilinKid AilinKid AilinKid left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zimulala @sre-bot @lysu @jackysp @AilinKid @zz-jason