log: support reloading tidb-query-max-log-len after modified #12491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhedu
changed the title
|
@fzhedu Thanks for your contribution! Please follow the Commit Message and Pull Request Style guide to reformat the PR title. BTW, you can use the keywords described in the Closing issues using keywords guide to close the related issue when this PR is merged. |
zz-jason
changed the title
fzhedu
changed the title
|
@fzhedu please remove all the irrelevant changes. |
…port tidb_query_log_max_len reload after modified
fzhedu
requested review from
SunRunAway,
AndreMouche and
jackysp
and removed request for
AndreMouche
|
Should we add it into the release note? |
|
SunRunAway
added
status/can-merge
Codecov Report
@@ Coverage Diff @@
## master #12491 +/- ##
===========================================
Coverage 79.8869% 79.8869%
===========================================
Files 461 461
Lines 103803 103803
===========================================
Hits 82925 82925
Misses 14791 14791
Partials 6087 6087 |
|
/run-all-tests |
|
/merge |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
improve the usability for the
tidb-query-max-log-lenWhat is changed and how it works?
change the default value of
tidb-query-max-log-lenfrom 2048 to 4096, and support reloadingtidb-query-max-log-lenafter modified in the config file.Check List
Tests
step 1: select the current value:
select @@tidb_query_log_max_len;step 2: change the value of
tidb-query-max-log-lenin the config filestep 3: reload the config
curl -X GET http://127.0.0.1:10080/reload-configstep 4: re-select the value:
select @@tidb_query_log_max_len;Code changes
Release note
tidb-query-max-log-lenfrom 2048 to 4096, and support reloadingtidb-query-max-log-lenafter modified in the config file.