Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix some window specific check bug for window function. (#12394) #12404

Merged
merged 3 commits into from
Oct 13, 2019

Conversation

lzmhhh123
Copy link
Contributor

cherry-pick #12394
planner: fix some window specific check bug for window function.

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 8, 2019
@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Oct 12, 2019

Sorry @SunRunAway, you don't have permission to trigger auto merge event on this branch.

@SunRunAway
Copy link
Contributor

@zz-jason

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

Your auto merge job has been accepted, waiting for 12463, 12566

@sre-bot
Copy link
Contributor

sre-bot commented Oct 13, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4fdfdf8 into pingcap:release-3.0 Oct 13, 2019
@lzmhhh123 lzmhhh123 deleted the cherry-pick-3.0-12394 branch October 14, 2019 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants