Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: replace pessimistic default config option with global variable(#12041) #12049

Merged
merged 1 commit into from
Sep 6, 2019
Merged

*: replace pessimistic default config option with global variable(#12041) #12049

merged 1 commit into from
Sep 6, 2019

Conversation

coocood
Copy link
Member

@coocood coocood commented Sep 5, 2019 •
edited
Loading

What problem does this PR solve?

Cherry-pick #12041
The 'PessimisticTxn.Default' option in the Config requires a server restart to change.
It can be inconsistent for multiple servers.

What is changed and how it works?

  • Add global scope for tidb_txn_mode system variable.
  • Remove PessimisticTxn.Default option in the config.
  • Change the default value of PessimisticTxn.Enable to true.

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository

Release note

  • Add global scope for tidb_txn_mode system variable, set enable option to 'true' and remove default option in the [pessimistic-txn] section of the config file.

@coocood
Copy link
Member Author

coocood commented Sep 5, 2019

Has many conflicts, need careful review, also added the missing TestValidate case.

@coocood coocood changed the title *: replace pessimistic default config option with global variable *: replace pessimistic default config option with global variable(#12041) Sep 5, 2019
lysu
lysu reviewed Sep 6, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2019
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2019
@lysu
Copy link
Contributor

lysu commented Sep 6, 2019

/run-all-tests

@jackysp jackysp merged commit ff58c3c into pingcap:release-3.0 Sep 6, 2019
@coocood coocood deleted the pessimistic-global-var-3.0 branch September 6, 2019 04:55
@liubo0127 liubo0127 mentioned this pull request Sep 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coocood @tiancaiamao @lysu @jackysp