*: refactor RestrictedSQLExecutor #11904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11904 +/- ##
===========================================
Coverage ? 81.2449%
===========================================
Files ? 438
Lines ? 94444
Branches ? 0
===========================================
Hits ? 76731
Misses ? 12221
Partials ? 5492 |
Codecov Report
@@ Coverage Diff @@
## master #11904 +/- ##
===========================================
Coverage 81.2562% 81.2562%
===========================================
Files 438 438
Lines 94453 94453
===========================================
Hits 76749 76749
Misses 12231 12231
Partials 5473 5473 |
ngaut
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What problem does this PR solve?
sessionctx.ContextinRestrictedSQLExecutoris useless.What is changed and how it works?
Refactor
RestrictedSQLExecutorto make it no longer depend onsessionctx.Check List
Tests
Code changes