expression: the quote function should treat null expr as NULL literal string instead of NULL #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
gaoxingliang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #11592 +/- ##
===========================================
Coverage 81.2404% 81.2404%
===========================================
Files 426 426
Lines 92033 92033
===========================================
Hits 74768 74768
Misses 11893 11893
Partials 5372 5372 |
zz-jason
added
component/expression
status/LGT1
XuHuaiyu
added
status/LGT2
|
/run-all-tests |
|
@gaoxingliang merge failed. |
|
/run-all-tests |
zz-jason
approved these changes
Aug 5, 2019
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11619 |
Could anyone resolve this? |
Thanks for your remind, see #11592 |
sre-bot
added a commit
to SunRunAway/tidb
that referenced
this pull request
Nov 25, 2019
…upstream-release-2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #11556 QUOTE(null) should return 'NULL' string instead of NULL value
What is changed and how it works?
if the expr is NULL, then the value for quote(expr) will be "NULL" instead of NULL.
Check List
Tests
Side effects