Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticlient: set max send/recv msg size match tikv's config #10706

Merged
merged 2 commits into from
Jun 5, 2019
Merged

ticlient: set max send/recv msg size match tikv's config #10706

merged 2 commits into from
Jun 5, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jun 4, 2019

What problem does this PR solve?

Now TiDB and TiKV use different max send/recv msg limit:

DB:

var MaxSendMsgSize = 1<<31 - 1

KV:

https://github.com/tikv/tikv/blob/8dae71abe25cdcc511116f7d5b29312dffc2b152/src/server/server.rs#L108

What is changed and how it works?

set TiDB's send to 10M and recv to ulimited(MaxInt)

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Jun 4, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #10706 into master will decrease coverage by 0.0351%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10706        +/-   ##
================================================
- Coverage   79.6786%   79.6434%   -0.0352%     
================================================
  Files           414        414                
  Lines         87696      87731        +35     
================================================
- Hits          69875      69872         -3     
- Misses        12647      12684        +37     
- Partials       5174       5175         +1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jun 5, 2019

A better way is to use a common config on these values for tidb and tikv.

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tikv status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants