Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong DATE/DATETIME comparison in BETWEEN function (#10313) #10407

Merged
merged 4 commits into from
May 10, 2019
Merged

planner: fix wrong DATE/DATETIME comparison in BETWEEN function (#10313) #10407

merged 4 commits into from
May 10, 2019

Conversation

erjiaqing
Copy link
Contributor

Cherry pick #10313 to 2.1

@erjiaqing erjiaqing requested review from zz-jason and winoros May 9, 2019 09:20
zz-jason
zz-jason reviewed May 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2019
@erjiaqing erjiaqing requested a review from qw4990 May 9, 2019 12:39
@zz-jason
Copy link
Member

zz-jason commented May 9, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

qw4990
qw4990 approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 10, 2019
@zhouqiang-cl
Copy link
Contributor

/rebuild

@zz-jason zz-jason merged commit 1bc58f4 into pingcap:release-2.1 May 10, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erjiaqing @zz-jason @zhouqiang-cl @qw4990 @sre-bot @ngaut