Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: control Chunk size for StreamAgg&HashAgg (#9512) #10133

Merged
merged 5 commits into from
Apr 15, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 12, 2019

cherry-pick for #9512

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 12, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested review from lysu and zz-jason April 12, 2019 07:42
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test is not picked?

executor/aggregate.go Outdated Show resolved Hide resolved
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 12, 2019

The unit test is not picked?

Their unit tests involve some other PRs' code which are not cherry-picked to v2.1;
So I didn't cherry-pick them to avoid make this PR too large just now.

Now all unit tests are cherry-picked and some involved change are also included by this PR.

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 12, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 15, 2019

PTAL

@qw4990 qw4990 requested review from zz-jason and alivxxx April 15, 2019 03:07
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 15, 2019
@qw4990
Copy link
Contributor Author

qw4990 commented Apr 15, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 356b0e5 into pingcap:release-2.1 Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants