Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test TestFinishAndUpdateOwnerAtSameTime #56599

Open
hawkingrei opened this issue Oct 12, 2024 · 1 comment
Open

flaky test TestFinishAndUpdateOwnerAtSameTime #56599

hawkingrei opened this issue Oct 12, 2024 · 1 comment

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

     result.go:49: 
        	Error Trace:	pkg/testkit/result.go:49
        	            				pkg/ttl/ttlworker/job_manager_integration_test.go:1360
        	Error:      	Not equal: 
        	            	expected: "[0]\n"
        	            	actual  : "[1]\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,2 @@
        	            	-[0]
        	            	+[1]
        	            	 
        	Test:       	TestFinishAndUpdateOwnerAtSameTime
        	Messages:   	sql:select count(*) from mysql.tidb_ttl_task, args:[] 

https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/56598/fast_test_tiprow/1844944156812644352#1:build-log.txt%3A4570

4. What is your TiDB version? (Required)

@YangKeao
Copy link
Member

It's because a deadlock error. It should be a test only issue as we have introduced retry mechanism in job.Finish. But I don't understand how the job.Finish and m.TaskManager().LockScanTask introduced deadlock 🤦 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants