Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#55306 may caused 8.1% performance regression in benchmarksql #55426

Open
owlsome2501 opened this issue Aug 15, 2024 · 7 comments
Open

PR#55306 may caused 8.1% performance regression in benchmarksql #55426

owlsome2501 opened this issue Aug 15, 2024 · 7 comments

Comments

@owlsome2501
Copy link

Bug Report

1. Minimal reproduce step (Required)

  1. Deploy a cluster with 3 TiDB and 3 Tikv.
  2. Run benchmark benchmarksql (benchmarksql-1k).

2. What did you expect to see? (Required)

No performance regression.

3. What did you see instead (Required)

#55306 caused QPS regression 8.13% in benchmark benchmarksql (benchmarksql-1k) compared to baseline 60193.12.

description tidb tikv pd QPS
last success 29d52a7 tikv/tikv@0e38069 tikv/pd@f3602e3 61176.30
first regression 9a7e5cc tikv/tikv@0e38069 tikv/pd@f3602e3 55297.83

4. What is your TiDB version? (Required)

9a7e5cc

@Yui-Song
Copy link
Contributor

/type performance
/type regression
/severity critical
/assign @hawkingrei
/sig planner
/label affects-8.3

@Yui-Song
Copy link
Contributor

The performance regression was caused by an intermittent hotspot issue that led to unbalanced TiKV CPU usage, rather than by PR#55306.
img_v3_02dq_9b7467a9-40bf-4931-af67-9f45921a0e0g
img_v3_02dq_80461dd5-ece6-438c-bbd3-59613c31846g
img_v3_02dq_e7544499-dbd8-462f-9758-72967a8cbdeg
img_v3_02dq_52a712ed-6a0b-471b-8e94-14501fc7867g

@Yui-Song
Copy link
Contributor

/remove-severity critical
/severity major

@Yui-Song
Copy link
Contributor

/remove-sig planner

@ti-chi-bot ti-chi-bot bot removed the sig/planner SIG: Planner label Aug 19, 2024
@Yui-Song
Copy link
Contributor

/label affects-7.5
/label affects-7.1
/label affects-8.1

@Yui-Song
Copy link
Contributor

The same performance instability has been observed in both TPC-C and BenchmarkSQL. It may be necessary to enhance the PD scheduling strategy by incorporating TiKV CPU usage as a factor, in order to reduce the occurrence of similar instability issues.

@Yui-Song
Copy link
Contributor

/assign @niubell
/unassign @hawkingrei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants