Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure consistent time zone behavior between TiDB and TiKV #49848

Open
XuHuaiyu opened this issue Dec 27, 2023 · 2 comments
Open

ensure consistent time zone behavior between TiDB and TiKV #49848

XuHuaiyu opened this issue Dec 27, 2023 · 2 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@XuHuaiyu
Copy link
Contributor

Enhancement

related issues:
#49586
#29427
tikv/tikv#16220

TiDB calculates time zones using the system's built-in tzinfo database, while TiKV calculates time zones using the embedded tzinfo database in the TiKV code (current version is 2018; fixed version is 2020). Therefore, when encountering time zones with DST rule changes after 2018, there are inconsistencies in the calculated results.
In #49586, the client's scenario is Brazil, where DST was discontinued from 2020 to 2023. However, TiKV incorrectly assumes that Brazil still follows DST during calculations.

@kennytm
Copy link
Contributor

kennytm commented Dec 27, 2023

IMO TiKV should just drop chrono-tz and replace it with e.g. hourglass that loads the tzdata directly from the OS rather than relying on those hard-coded into the binary.

@Defined2014
Copy link
Contributor

Add one more issue maybe related with this one. #8452

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants