Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan replayer cannot handle a standard zip file contains directories. #46474

Closed
YangKeao opened this issue Aug 29, 2023 · 0 comments · Fixed by #47474
Closed

plan replayer cannot handle a standard zip file contains directories. #46474

YangKeao opened this issue Aug 29, 2023 · 0 comments · Fixed by #47474
Assignees
@YangKeao
Labels
affects-6.5 affects-7.1 severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@YangKeao
Copy link
Member

A normal zip archive stores both files and directories as entries. For example, a zip contains only a file schema/some.sql will also contain "schema/", which is a directory entry.

So if someone decompressed the zip provided replayer and compress it again, TiDB will not be able to read it. (But luckily, most zip readers are able to read the zip provided by TiDB. They are good at handling corner cases 🤦 ).
@YangKeao YangKeao added type/bug The issue is confirmed as a bug. sig/planner SIG: Planner severity/moderate severity/minor and removed severity/moderate labels Aug 29, 2023
@YangKeao YangKeao self-assigned this Aug 29, 2023
@YangKeao YangKeao mentioned this issue Oct 9, 2023
Merged
4 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 11, 2023
@YangKeao
executor, planner: fix plan_replayer zip format (#47474)
c27c73c 
close #46474
This was referenced Oct 17, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@ti-chi-bot
executor, planner: fix plan_replayer zip format (#47474) (#47713)
266a56d 
close #46474
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@ti-chi-bot
executor, planner: fix plan_replayer zip format (#47474) (#47714)
9015774 
close #46474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YangKeao YangKeao

Labels
affects-6.5 affects-7.1 severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor, planner: fix plan_replayer zip format YangKeao/tidb
2 participants
@YangKeao @ti-chi-bot