Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br backup to aliyum OSS not support ak/sk as env #45551

Closed
knull-cn opened this issue Jul 25, 2023 · 7 comments · Fixed by #54150
Closed

br backup to aliyum OSS not support ak/sk as env #45551

knull-cn opened this issue Jul 25, 2023 · 7 comments · Fixed by #54150
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.5 affects-8.1 component/br This issue is related to BR of TiDB. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/moderate type/enhancement The issue or PR belongs to an enhancement.

Comments

@knull-cn
Copy link
Contributor

knull-cn commented Jul 25, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. set env AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY
  2. br full backup --s3.provider "alibaba" --s3.endpoint "xxx" xxxxx

2. What did you expect to see? (Required)

access OSS sucess

3. What did you see instead (Required)

access by RAM first
get AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY by env args was latter by s3 lib

4. What is your TiDB version? (Required)

v7.1.0
(OSS was import in v6.1.0 ,so this bug was in >= v6.1.0)
@knull-cn knull-cn added the type/bug The issue is confirmed as a bug. label Jul 25, 2023
@knull-cn
Copy link
Contributor Author

aliyun OSS only use RAM access , but not check env provider first
https://github.com/pingcap/tidb/blob/v6.1.0/br/pkg/storage/s3.go#L266-L273

@3pointer
Copy link
Contributor

Do you mean RAM and AK/SK have different permissions? they are different?
What's the actual error in this scenario?

@jebter jebter added severity/major component/br This issue is related to BR of TiDB. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 labels Jul 26, 2023
@BornChanger
Copy link
Contributor

/severity moderate

@BornChanger
Copy link
Contributor

@knull-cn do you mind raising a pr for this issue?

@BornChanger
Copy link
Contributor

/remove-severity major

@BornChanger
Copy link
Contributor

/remove-type bug

@ti-chi-bot ti-chi-bot bot removed the type/bug The issue is confirmed as a bug. label Mar 27, 2024
@BornChanger
Copy link
Contributor

/type enhancement

@ti-chi-bot ti-chi-bot bot added the type/enhancement The issue or PR belongs to an enhancement. label Mar 27, 2024
@BornChanger BornChanger mentioned this issue May 27, 2024
Closed
@BornChanger BornChanger added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 27, 2024
@RidRisR RidRisR mentioned this issue Jun 21, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 9d860fc Jul 2, 2024
@jebter jebter removed may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Jul 11, 2024
@ti-chi-bot ti-chi-bot mentioned this issue Jul 11, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 22, 2024
@ti-chi-bot
br: fix backup to aliyum OSS not support ak/sk as env (#54150) (#54579)
c77a7ba 
close #45551
@ti-chi-bot ti-chi-bot mentioned this issue Jul 29, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Aug 5, 2024
@ti-chi-bot
br: fix backup to aliyum OSS not support ak/sk as env (#54150) (#54994)
5863a6f 
close #45551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 affects-7.5 affects-8.1 component/br This issue is related to BR of TiDB. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/moderate type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

br: fix backup to aliyum OSS not support ak/sk as env RidRisR/tidb
4 participants
@jebter @knull-cn @3pointer @BornChanger