Panic triggered at core.(*LogicalProjection).TryToGetChildProp (planner/core/exhaust_physical_plans.go:2500) #42734
Assignees
Labels
affects-7.1
affects-7.5
affects-8.1
severity/major
sig/planner
SIG: Planner
type/bug
The issue is confirmed as a bug.
Comments
JZuming
changed the title
ti-chi-bot
added
may-affects-4.0
|
/assign @terry1purcell |
|
@fixdb: GitHub didn't allow me to assign the following users: terry1purcell. Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I am working on this. |
|
I can reproduce it on the nightly build. |
|
Debugging note: use test;
CREATE TABLE temperature_data (temperature double);
CREATE TABLE humidity_data (humidity double);
CREATE TABLE weather_report (report_id double, report_date varchar(100));
INSERT INTO temperature_data VALUES (1.0);
INSERT INTO humidity_data VALUES (0.5);
INSERT INTO weather_report VALUES (2.0, 'test');
SELECT
EXISTS (
SELECT
FIRST_VALUE(temp_data.temperature) OVER weather_window AS first_temperature,
MIN(report_data.report_id) OVER weather_window AS min_report_id
FROM
temperature_data AS temp_data
WINDOW weather_window AS (
PARTITION BY EXISTS (
SELECT
report_data.report_date AS report_date
FROM
humidity_data AS humidity_data
WHERE temp_data.temperature >= humidity_data.humidity
)
)
) AS is_exist
FROM
weather_report AS report_data;I found that if we remove the predicate It panic at: // TryToGetChildProp will check if this sort property can be pushed or not.
// When a sort column will be replaced by scalar function, we refuse it.
// When a sort column will be replaced by a constant, we just remove it.
func (p *LogicalProjection) TryToGetChildProp(prop *property.PhysicalProperty) (*property.PhysicalProperty, bool) {
newProp := prop.CloneEssentialFields()
newCols := make([]property.SortItem, 0, len(prop.SortItems))
for _, col := range prop.SortItems {
idx := p.schema.ColumnIndex(col.Col)
if idx == -1 {
logutil.BgLogger().Info("column not found in schema", zap.String("column", col.Col.String()))
}
switch expr := p.Exprs[idx].(type) {
case *expression.Column:
newCols = append(newCols, property.SortItem{Col: expr, Desc: col.Desc})
case *expression.ScalarFunction:
return nil, false
}
}
newProp.SortItems = newCols
return newProp, true
}We cannot find the sort item in the projection's schema. If we remove the predicate, we can find it correctly. For example: mysql> explain SELECT
-> EXISTS (
-> SELECT
-> FIRST_VALUE(temp_data.temperature) OVER weather_window AS first_temperature,
-> MIN(report_data.report_id) OVER weather_window AS min_report_id
-> FROM
-> temperature_data AS temp_data
-> WINDOW weather_window AS (
-> PARTITION BY EXISTS (
-> SELECT
-> report_data.report_date AS report_date
-> FROM
-> humidity_data AS humidity_data
-> )
-> )
-> ) AS is_exist
-> FROM
-> weather_report AS report_data;
+--------------------------------+--------------+-----------+-------------------+-------------------------------------------------------------------------------------------------------------------+
| id | estRows | task | access object | operator info |
+--------------------------------+--------------+-----------+-------------------+-------------------------------------------------------------------------------------------------------------------+
| Projection_15 | 10000.00 | root | | Column#20 |
| └─Apply_17 | 10000.00 | root | | CARTESIAN left outer semi join |
| ├─TableReader_19(Build) | 10000.00 | root | | data:TableFullScan_18 |
| │ └─TableFullScan_18 | 10000.00 | cop[tikv] | table:report_data | keep order:false, stats:pseudo |
| └─Window_20(Probe) | 100000000.00 | root | | first_value(test.temperature_data.temperature)->Column#16, min(Column#15)->Column#17 over(partition by Column#14) |
| └─Projection_21 | 100000000.00 | root | | test.temperature_data.temperature, 0->Column#14, test.weather_report.report_id->Column#15 |
| └─TableReader_24 | 100000000.00 | root | | data:TableFullScan_23 |
| └─TableFullScan_23 | 100000000.00 | cop[tikv] | table:temp_data | keep order:false, stats:pseudo |
+--------------------------------+--------------+-----------+-------------------+-------------------------------------------------------------------------------------------------------------------+ |
13 tasks
Rustin170506
removed
may-affects-4.0
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this issue
Apr 11, 2024
This was referenced Apr 11, 2024
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this issue
Jul 29, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
Setup the database:
Testcase
2. What did you expect to see? (Required)
No error was triggered.
3. What did you see instead (Required)
TiDB log:
4. What is your TiDB version? (Required)
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v7.1.0-alpha-27-gf5ca27ef3
Edition: Community
Git Commit Hash: f5ca27e
Git Branch: master
UTC Build Time: 2023-03-23 13:57:53
GoVersion: go1.20.2
Race Enabled: false
TiKV Min Version: 6.2.0-alpha
Check Table Before Drop: false
Store: unistore |
+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
The text was updated successfully, but these errors were encountered: