Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forget to use physical ID in checkBackfillJobCount #42175

Closed
Tracked by #37119
zimulala opened this issue Mar 13, 2023 · 0 comments · Fixed by #42204
Closed
Tracked by #37119

Forget to use physical ID in checkBackfillJobCount #42175

zimulala opened this issue Mar 13, 2023 · 0 comments · Fixed by #42204
Assignees
Labels
affects-6.6 severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@zimulala
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

tidb/ddl/dist_owner.go

Lines 459 to 473 in 21aa40f

func checkBackfillJobCount(sess *session, ddlJobID, currEleID int64, currEleKey []byte, pTblID int64) (backfillJobCnt int, err error) {
err = checkAndHandleInterruptedBackfillJobs(sess, ddlJobID, currEleID, currEleKey)
if err != nil {
return 0, errors.Trace(err)
}
backfillJobCnt, err = GetBackfillJobCount(sess, BackgroundSubtaskTable,
fmt.Sprintf("task_key like \"%d_%s_%d_%%\"",
ddlJobID, hex.EncodeToString(currEleKey), currEleID), "check_backfill_job_count")
if err != nil {
return 0, errors.Trace(err)
}
return backfillJobCnt, nil
}

Forget to use pTblID.
Related PR: #41093.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

https://github.com/pingcap/tidb/pull/41093/files#diff-b493c3e8047646e9d597e05480ab2f44467ca8b035b7ac9f44c8ac1af55f15e4L449

4. What is your TiDB version? (Required)

https://github.com/pingcap/tidb/pull/41093/files#diff-b493c3e8047646e9d597e05480ab2f44467ca8b035b7ac9f44c8ac1af55f15e4R449

master
v6.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.6 severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant