-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planner generates wrong 2 phase aggregate plan for TiFlash #34682
Labels
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
affects-5.3
This bug affects 5.3.x versions.
affects-5.4
This bug affects 5.4.x versions.
affects-6.0
affects-6.1
severity/critical
sig/planner
SIG: Planner
type/bug
The issue is confirmed as a bug.
Comments
12 tasks
ti-chi-bot
added
may-affects-4.0
This bug maybe affects 4.0.x versions.
may-affects-5.0
This bug maybe affects 5.0.x versions.
may-affects-5.1
This bug maybe affects 5.1.x versions.
may-affects-5.2
This bug maybe affects 5.2.x versions.
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-6.0
may-affects-6.1
labels
May 23, 2022
jebter
added
affects-6.1
and removed
may-affects-4.0
This bug maybe affects 4.0.x versions.
may-affects-5.1
This bug maybe affects 5.1.x versions.
may-affects-5.2
This bug maybe affects 5.2.x versions.
may-affects-5.3
This bug maybe affects 5.3.x versions.
may-affects-5.4
This bug maybe affects 5.4.x versions.
may-affects-5.0
This bug maybe affects 5.0.x versions.
may-affects-6.0
may-affects-6.1
labels
May 23, 2022
Why is planner bug assigned to me? @jebter |
fixdb
added a commit
to fixdb/tidb
that referenced
this issue
May 24, 2022
…for TiFlash When pushing down aggregate past join operator, the planner updates the top aggregate from CompleteMode to FinalMode. But in MPP, the planner again tries to split the top aggregate into 2 stage aggregate: 1 partial aggregate on TiFlash, 1 Final aggregate on TiDB. The newly created partial aggregate will ignore the partial aggregate result that comes under the join and treats the data as standard input data, hence causes wrong result. In this patch, we disable splitting aggregate into multiple stages if the aggregate is in final mode. Close pingcap#34682
jebter
added
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
affects-5.3
This bug affects 5.3.x versions.
affects-5.4
This bug affects 5.4.x versions.
affects-6.0
labels
May 26, 2022
chrysan
removed
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
affects-5.3
This bug affects 5.3.x versions.
affects-5.4
This bug affects 5.4.x versions.
labels
Jun 14, 2022
chrysan
added
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
affects-5.3
This bug affects 5.3.x versions.
affects-5.4
This bug affects 5.4.x versions.
labels
Jun 14, 2022
Needs triage and cherry-pick to old versions from v5.0... |
12 tasks
fixdb
added a commit
to fixdb/tidb
that referenced
this issue
Jun 16, 2022
…for TiFlash When pushing down aggregate past join operator, the planner updates the top aggregate from CompleteMode to FinalMode. But in MPP, the planner again tries to split the top aggregate into 2 stage aggregate: 1 partial aggregate on TiFlash, 1 Final aggregate on TiDB. The newly created partial aggregate will ignore the partial aggregate result that comes under the join and treats the data as standard input data, hence causes wrong result. In this patch, we disable splitting aggregate into multiple stages if the aggregate is in final mode. Close pingcap#34682
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects-5.0
This bug affects 5.0.x versions.
affects-5.1
This bug affects 5.1.x versions.
affects-5.2
This bug affects 5.2.x versions.
affects-5.3
This bug affects 5.3.x versions.
affects-5.4
This bug affects 5.4.x versions.
affects-6.0
affects-6.1
severity/critical
sig/planner
SIG: Planner
type/bug
The issue is confirmed as a bug.
Bug Report
1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: