Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATA RACE in the TestStartWithRunGCJobFailures #33262

Open
Tracked by #33745
hawkingrei opened this issue Mar 20, 2022 · 0 comments
Open
Tracked by #33745

DATA RACE in the TestStartWithRunGCJobFailures #33262

hawkingrei opened this issue Mar 20, 2022 · 0 comments
Labels
affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.5 affects-8.1 component/GC component/test may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

==================
[2022/03/20 12:31:46.642 +00:00] [ERROR] [gc_worker.go:227] ["[gc worker] runGCJob"] [error="mock error"] [errorVerbose="mock error\ngithub.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures\n\t/go/tidb/store/gcworker/gc_worker_test.go:1140\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1259\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1581"] [stack="github.com/pingcap/tidb/store/gcworker.(*GCWorker).start\n\t/go/tidb/store/gcworker/gc_worker.go:227"]
[2022/03/20 12:31:46.643 +00:00] [ERROR] [gc_worker.go:227] ["[gc worker] runGCJob"] [error="mock error"] [errorVerbose="mock error\ngithub.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures\n\t/go/tidb/store/gcworker/gc_worker_test.go:1140\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:1259\nruntime.goexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1581"] [stack="github.com/pingcap/tidb/store/gcworker.(*GCWorker).start\n\t/go/tidb/store/gcworker/gc_worker.go:227"]
WARNING: DATA RACE
Write at 0x00c0015cef80 by goroutine 213:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).start()
      /go/tidb/store/gcworker/gc_worker.go:224 +0x475
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start·dwrap·1()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x64
Previous write at 0x00c0015cef80 by goroutine 59:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).start()
      /go/tidb/store/gcworker/gc_worker.go:224 +0x475
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start·dwrap·1()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x64
Goroutine 213 (running) created at:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x1b8
  github.com/pingcap/tidb/store/gcworker.createGCWorkerSuite()
      /go/tidb/store/gcworker/gc_worker_test.go:127 +0x648
  github.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures()
      /go/tidb/store/gcworker/gc_worker_test.go:1130 +0x4a
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Goroutine 59 (running) created at:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x1b8
  github.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures()
      /go/tidb/store/gcworker/gc_worker_test.go:1133 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================
==================
WARNING: DATA RACE
Write at 0x00c0015cef88 by goroutine 213:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).start()
      /go/tidb/store/gcworker/gc_worker.go:225 +0x4b1
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start·dwrap·1()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x64
Previous write at 0x00c0015cef88 by goroutine 59:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).start()
      /go/tidb/store/gcworker/gc_worker.go:225 +0x4b1
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start·dwrap·1()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x64
Goroutine 213 (running) created at:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x1b8
  github.com/pingcap/tidb/store/gcworker.createGCWorkerSuite()
      /go/tidb/store/gcworker/gc_worker_test.go:127 +0x648
  github.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures()
      /go/tidb/store/gcworker/gc_worker_test.go:1130 +0x4a
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
Goroutine 59 (running) created at:
  github.com/pingcap/tidb/store/gcworker.(*GCWorker).Start()
      /go/tidb/store/gcworker/gc_worker.go:116 +0x1b8
  github.com/pingcap/tidb/store/gcworker.TestStartWithRunGCJobFailures()
      /go/tidb/store/gcworker/gc_worker_test.go:1133 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1259 +0x22f
  testing.(*T).Run·dwrap·21()
      /usr/local/go/src/testing/testing.go:1306 +0x47
==================

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Mar 20, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 labels Mar 21, 2022
@hawkingrei hawkingrei mentioned this issue Apr 7, 2022
Open
25 tasks
@hawkingrei hawkingrei changed the title DATA RACE in the GCWorker DATA RACE in the TestStartWithRunGCJobFailures Apr 7, 2022
@jebter jebter added the sig/transaction SIG:Transaction label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.5 affects-8.1 component/GC component/test may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hawkingrei @jebter @VelocityLight @ti-chi-bot @vivid392845427