Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression found for BenchmarkStringIndexScan #32163

Closed
tiancaiamao opened this issue Feb 8, 2022 · 2 comments
Closed

Performance regression found for BenchmarkStringIndexScan #32163

tiancaiamao opened this issue Feb 8, 2022 · 2 comments
Labels
severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@tiancaiamao
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

image

http://www.zenlife.tk:18081/alloc

Apparently, yet another regression!

2022-02-07~2022-02-08

Found by #25754

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

16cd0e2

@tiancaiamao tiancaiamao added the type/bug The issue is confirmed as a bug. label Feb 8, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Feb 8, 2022

cd session;
go test -run XXX -bench  BenchmarkStringIndexScan -benchtime 30s -benchmem -memprofile mem.out

#32016 is highly suspected @wjhuang2016

master
BenchmarkStringIndexScan-16 135544 263787 ns/op 97440 B/op 1681 allocs/op

pr32016
BenchmarkStringIndexScan-16 142130 251971 ns/op 94065 B/op 1478 allocs/op

@tiancaiamao
Copy link
Contributor Author

From @wjhuang2016, after enabling collation, this regression is expected.
So close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

2 participants