Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some unit tests are not enabled and cannot pass #24249

Open
disksing opened this issue Apr 23, 2021 · 0 comments
Open

Some unit tests are not enabled and cannot pass #24249

disksing opened this issue Apr 23, 2021 · 0 comments
Labels
affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.5 affects-8.1 component/pd component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@disksing
Copy link
Contributor

disksing commented Apr 23, 2021 •
edited
Loading

We use pingcap/check for unit testing and it requires calling check.TestingT in every package.

With following script, we can find some packages do not have TestingT:

 bash <(curl -Ls https://github.com/tikv/pd/raw/master/scripts/check-testing-t.sh)
@disksing disksing added the type/bug The issue is confirmed as a bug. label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.0 affects-6.1 affects-6.2 affects-6.3 affects-6.4 affects-6.5 affects-6.6 affects-7.0 affects-7.1 affects-7.5 affects-8.1 component/pd component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jebter @VelocityLight @aytrack @disksing @ti-chi-bot