Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize error codes and messages for error class ClassExpression #18481

Open
23 tasks
imtbkcat opened this issue Jul 10, 2020 · 1 comment
Open
23 tasks

Standardize error codes and messages for error class ClassExpression #18481

imtbkcat opened this issue Jul 10, 2020 · 1 comment
Assignees
@qw4990
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@imtbkcat
Copy link

imtbkcat commented Jul 10, 2020 •
edited
Loading

Development Task

Add workaround for errors which belong to ClassExpression

This task need to add description and workaround for these errors:

position: expression/errors.go

  • ErrIncorrectParameterCount
  • ErrDivisionByZero
  • ErrRegexp
  • ErrOperandColumns
  • ErrCutValueGroupConcat
  • ErrFunctionsNoopImpl
  • ErrIncorrectType
  • errFunctionNotExists
  • errZlibZData
  • errZlibZBuf
  • errIncorrectArgs
  • errUnknownCharacterSet
  • errDefaultValue
  • errDeprecatedSyntaxNoReplacement
  • errBadField(expression/errors.go#42)
  • errWarnAllowedPacketOverflowed
  • errWarnOptionIgnored
  • errTruncatedWrongValue
  • errUnknownLocale
  • errNonUniq
  • errSequenceAccessDenied
  • errTooBigPrecision(planner/core/errors/go#71)
  • ErrIllegalMixCollation(util/collate.go#39)

Here is a example:

[error.9005]
error = '''Region is unavailable'''
description = '''
A certain Raft Group is not available, such as the number of replicas is not enough.
This error usually occurs when the TiKV server is busy or the TiKV node is down.
'''
workaround = '''Check the status, monitoring data and log of the TiKV server.'''

Error code and error message has been saved when the error registered. So just need a description to describe what happen when this error occur and a workaround to let user know how to deal with it.
@imtbkcat imtbkcat added the type/enhancement The issue or PR belongs to an enhancement. label Jul 10, 2020
@zz-jason zz-jason assigned SunRunAway and unassigned zz-jason Jul 10, 2020
@lzmhhh123 lzmhhh123 assigned qw4990 and unassigned SunRunAway Jul 23, 2020
@lzmhhh123
Copy link
Contributor

@qw4990 PTAL.

@qw4990 qw4990 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SunRunAway @zz-jason @qw4990 @imtbkcat @lzmhhh123