Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add units to the numeric options in the configuration file #17847

Open
tangenta opened this issue Jun 8, 2020 · 1 comment
Open

Add units to the numeric options in the configuration file #17847

tangenta opened this issue Jun 8, 2020 · 1 comment
Labels
component/config feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue or PR as related to a new feature. type/usability

Comments

@tangenta
Copy link
Contributor

tangenta commented Jun 8, 2020

Feature Request

Is your feature request related to a problem? Please describe:

Most of the numeric configs lack unit. It is easy to confuse users. For example,

txn-total-size-limit = 104857600

104857600 should be 104857600B and 10737418240 should be 10737418240B or 10G.

Here is another example causing problems: #17434.
#17434 (comment)

Describe the feature you'd like:

  • Add units to the numeric options in the configuration file.
  • Forbid numeric options without units.

Describe alternatives you've considered:

  • Explain the units in documents
  • Explain the units in the configuration file comments

Both of these solutions are not easy to use enough.

Teachability, Documentation, Adoption, Migration Strategy:

Change how the configuration file is parsed.

@tangenta tangenta added type/usability component/config type/feature-request Categorizes issue or PR as related to a new feature. labels Jun 8, 2020
@tangenta tangenta added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 8, 2020
@djshow832 djshow832 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 8, 2020
@scsldb scsldb added the feature/reviewing This feature request is reviewing by product managers label Jul 16, 2020
@zz-jason
Copy link
Member

zz-jason commented Jul 22, 2020

@tangenta Seems we need to rewrite the log parse module. Is it easy to do this?

@zz-jason zz-jason removed their assignment Jul 23, 2020
@zz-jason zz-jason removed the feature/reviewing This feature request is reviewing by product managers label Jul 23, 2020
@zz-jason zz-jason added the feature/accepted This feature request is accepted by product managers label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/feature-request Categorizes issue or PR as related to a new feature. type/usability
Projects
None yet
Development

No branches or pull requests

4 participants