Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed Query OPM only counts the error count for ComQuery #16384

Open
XuHuaiyu opened this issue Apr 15, 2020 · 0 comments
Open

Failed Query OPM only counts the error count for ComQuery #16384

XuHuaiyu opened this issue Apr 15, 2020 · 0 comments
Labels
component/metrics help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.

Comments

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 15, 2020 •
edited
Loading

Bug Report

Now, we count the error count in handleQuery which is only valid for ComQuery.
Actually, we should count the error for all commands. Or, some errors may be lost if the command is not ComQuery.

https://github.com/pingcap/tidb/blob/master/server/conn.go#L1270-L1287
@XuHuaiyu XuHuaiyu added type/bug The issue is confirmed as a bug. component/metrics labels Apr 15, 2020
@XuHuaiyu XuHuaiyu added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 15, 2020
@zz-jason zz-jason added this to the v4.0.0-ga milestone Apr 15, 2020
@SunRunAway SunRunAway modified the milestones: v4.0.0-ga, v4.0.1 May 28, 2020
@zz-jason zz-jason modified the milestones: v4.0.1, v4.0.2 Jun 5, 2020
@zz-jason zz-jason modified the milestones: v4.0.2, v4.0.3 Jun 19, 2020
@winoros winoros modified the milestones: v4.0.3, v4.0.4 Jul 14, 2020
@imtbkcat imtbkcat modified the milestones: v4.0.4, v4.0.5, v4.0.6 Jul 28, 2020
@AilinKid AilinKid modified the milestones: v4.0.6, 4.0.7 Sep 8, 2020
@lzmhhh123 lzmhhh123 modified the milestones: v4.0.7, v4.0.8 Sep 21, 2020
@bb7133 bb7133 modified the milestones: v4.0.8, v4.0.9 Nov 4, 2020
@zz-jason zz-jason removed this from the v4.0.9 milestone Nov 30, 2020
@jebter jebter added the sig/execution SIG execution label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/metrics help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/execution SIG execution type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@SunRunAway @bb7133 @jebter @zz-jason @winoros @XuHuaiyu @imtbkcat @AilinKid @lzmhhh123 @sre-bot