Result of DATE_ADD function is different from mysql.(YEAR overflow)

[wshwsh12]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?
   If possible, provide a recipe for reproducing the error.

select DATE_ADD('2000-04-13 07:17:02',INTERVAL -1465647104 YEAR);
select DATE_ADD('2008-11-23 22:47:31',INTERVAL 266076160 QUARTER);

2. What did you expect to see?

mysql> select DATE_ADD('2000-04-13 07:17:02',INTERVAL -1465647104 YEAR);
+-----------------------------------------------------------+
| DATE_ADD('2000-04-13 07:17:02',INTERVAL -1465647104 YEAR) |
+-----------------------------------------------------------+
| NULL                                                      |
+-----------------------------------------------------------+
1 row in set, 1 warning (0.01 sec)

mysql> select DATE_ADD('2008-11-23 22:47:31',INTERVAL 266076160 QUARTER);
+------------------------------------------------------------+
| DATE_ADD('2008-11-23 22:47:31',INTERVAL 266076160 QUARTER) |
+------------------------------------------------------------+
| NULL                                                       |
+------------------------------------------------------------+
1 row in set, 1 warning (0.00 sec)

3. What did you see instead?

mysql> select DATE_ADD('2000-04-13 07:17:02',INTERVAL -1465647104 YEAR);
+-----------------------------------------------------------+
| DATE_ADD('2000-04-13 07:17:02',INTERVAL -1465647104 YEAR) |
+-----------------------------------------------------------+
| 2000-04-13 07:17:02                                       |
+-----------------------------------------------------------+
1 row in set (0.00 sec)

mysql> select DATE_ADD('2008-11-23 22:47:31',INTERVAL 266076160 QUARTER);
+------------------------------------------------------------+
| DATE_ADD('2008-11-23 22:47:31',INTERVAL 266076160 QUARTER) |
+------------------------------------------------------------+
| 2008-11-23 22:47:31                                        |
+------------------------------------------------------------+
1 row in set (0.00 sec)

4. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

| Release Version: v3.0.0-rc.1-338-g3f1d234e2
Git Commit Hash: 3f1d234e2036a3163f7774ff106fa6397d585287
Git Branch: master
UTC Build Time: 2019-07-15 08:34:52
GoVersion: go version go1.12.6 darwin/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false |

[AndrewDi]

It seems like our MysqlTime function will convert invalid year to uint16, and this will reset invalid int.

tidb/types/time.go

Lines 204 to 214 in 5611acd

	func FromDate(year int, month int, day int, hour int, minute int, second int, microsecond int) MysqlTime {
	return MysqlTime{
	uint16(year),
	uint8(month),
	uint8(day),
	hour,
	uint8(minute),
	uint8(second),
	uint32(microsecond),
	}
	}