-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
expression: consider collations when comparing strings (#14913)
- Loading branch information
Showing
18 changed files
with
148 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| // Copyright 2020 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package expression | ||
|
|
||
| import ( | ||
| . "github.com/pingcap/check" | ||
| "github.com/pingcap/parser/mysql" | ||
| "github.com/pingcap/tidb/types" | ||
| "github.com/pingcap/tidb/util/chunk" | ||
| "github.com/pingcap/tidb/util/collate" | ||
| "github.com/pingcap/tidb/util/mock" | ||
| ) | ||
|
|
||
| var _ = SerialSuites(&testCollationSuites{}) | ||
|
|
||
| type testCollationSuites struct{} | ||
|
|
||
| func (s *testCollationSuites) TestCompareString(c *C) { | ||
| collate.SetNewCollationEnabledForTest(true) | ||
| defer collate.SetNewCollationEnabledForTest(false) | ||
|
|
||
| c.Assert(types.CompareString("a", "A", "utf8_general_ci", 1), Equals, 0) | ||
| c.Assert(types.CompareString("À", "A", "utf8_general_ci", 1), Equals, 0) | ||
| c.Assert(types.CompareString("😜", "😃", "utf8_general_ci", 1), Equals, 0) | ||
| c.Assert(types.CompareString("a ", "a ", "utf8_general_ci", 3), Equals, 0) | ||
| c.Assert(types.CompareString("a", "A", "binary", 1), Not(Equals), 0) | ||
| c.Assert(types.CompareString("À", "A", "binary", 1), Not(Equals), 0) | ||
| c.Assert(types.CompareString("😜", "😃", "binary", 1), Not(Equals), 0) | ||
| c.Assert(types.CompareString("a ", "a ", "binary", 3), Not(Equals), 0) | ||
|
|
||
| ctx := mock.NewContext() | ||
| ft := types.NewFieldType(mysql.TypeVarString) | ||
| col1 := &Column{ | ||
| RetType: ft, | ||
| Index: 0, | ||
| } | ||
| col2 := &Column{ | ||
| RetType: ft, | ||
| Index: 1, | ||
| } | ||
| chk := chunk.NewChunkWithCapacity([]*types.FieldType{ft, ft}, 4) | ||
| chk.Column(0).AppendString("a") | ||
| chk.Column(1).AppendString("A") | ||
| chk.Column(0).AppendString("À") | ||
| chk.Column(1).AppendString("A") | ||
| chk.Column(0).AppendString("😜") | ||
| chk.Column(1).AppendString("😃") | ||
| chk.Column(0).AppendString("a ") | ||
| chk.Column(1).AppendString("a ") | ||
| for i := 0; i < 4; i++ { | ||
| v, isNull, err := CompareStringWithCollationInfo(ctx, col1, col2, chk.GetRow(0), chk.GetRow(0), "utf8_general_ci", 3) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(isNull, IsFalse) | ||
| c.Assert(v, Equals, int64(0)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.