From ab01065a8541cab6eae0e6a0e6297d6047d7feb7 Mon Sep 17 00:00:00 2001
From: CbcWestwolf <1004626265@qq.com>
Date: Tue, 27 Dec 2022 10:56:17 +0800
Subject: [PATCH] metrics: remove Keep Alive OPM metric (#40142)

close pingcap/tidb#40143
---
 metrics/metrics.go                  |  1 -
 metrics/server.go                   |  8 --------
 tidb-server/main.go                 | 11 +----------
 util/systimemon/systime_mon.go      |  9 +--------
 util/systimemon/systime_mon_test.go |  2 +-
 5 files changed, 3 insertions(+), 28 deletions(-)

diff --git a/metrics/metrics.go b/metrics/metrics.go
index f609caaa124cd..8f303ba58180e 100644
--- a/metrics/metrics.go
+++ b/metrics/metrics.go
@@ -124,7 +124,6 @@ func RegisterMetrics() {
 	prometheus.MustRegister(SyncLoadHistogram)
 	prometheus.MustRegister(ReadStatsHistogram)
 	prometheus.MustRegister(JobsGauge)
-	prometheus.MustRegister(KeepAliveCounter)
 	prometheus.MustRegister(LoadPrivilegeCounter)
 	prometheus.MustRegister(InfoCacheCounters)
 	prometheus.MustRegister(LoadSchemaCounter)
diff --git a/metrics/server.go b/metrics/server.go
index 6bd34c4a8b903..830e03b28e986 100644
--- a/metrics/server.go
+++ b/metrics/server.go
@@ -120,14 +120,6 @@ var (
 			Help:      "Counter of system time jumps backward.",
 		})
 
-	KeepAliveCounter = prometheus.NewCounter(
-		prometheus.CounterOpts{
-			Namespace: "tidb",
-			Subsystem: "monitor",
-			Name:      "keep_alive_total",
-			Help:      "Counter of TiDB keep alive.",
-		})
-
 	PlanCacheCounter = prometheus.NewCounterVec(
 		prometheus.CounterOpts{
 			Namespace: "tidb",
diff --git a/tidb-server/main.go b/tidb-server/main.go
index 8605c7d0c3aaa..0e42c059e6c05 100644
--- a/tidb-server/main.go
+++ b/tidb-server/main.go
@@ -788,16 +788,7 @@ func setupMetrics() {
 	systimeErrHandler := func() {
 		metrics.TimeJumpBackCounter.Inc()
 	}
-	callBackCount := 0
-	successCallBack := func() {
-		callBackCount++
-		// It is callback by monitor per second, we increase metrics.KeepAliveCounter per 5s.
-		if callBackCount >= 5 {
-			callBackCount = 0
-			metrics.KeepAliveCounter.Inc()
-		}
-	}
-	go systimemon.StartMonitor(time.Now, systimeErrHandler, successCallBack)
+	go systimemon.StartMonitor(time.Now, systimeErrHandler)
 
 	pushMetric(cfg.Status.MetricsAddr, time.Duration(cfg.Status.MetricsInterval)*time.Second)
 }
diff --git a/util/systimemon/systime_mon.go b/util/systimemon/systime_mon.go
index 67b23ed894b5b..26819a4159776 100644
--- a/util/systimemon/systime_mon.go
+++ b/util/systimemon/systime_mon.go
@@ -22,11 +22,10 @@ import (
 )
 
 // StartMonitor calls systimeErrHandler if system time jump backward.
-func StartMonitor(now func() time.Time, systimeErrHandler func(), successCallback func()) {
+func StartMonitor(now func() time.Time, systimeErrHandler func()) {
 	logutil.BgLogger().Info("start system time monitor")
 	tick := time.NewTicker(100 * time.Millisecond)
 	defer tick.Stop()
-	tickCount := 0
 	for {
 		last := now().UnixNano()
 		<-tick.C
@@ -34,11 +33,5 @@ func StartMonitor(now func() time.Time, systimeErrHandler func(), successCallbac
 			logutil.BgLogger().Error("system time jump backward", zap.Int64("last", last))
 			systimeErrHandler()
 		}
-		// call successCallback per second.
-		tickCount++
-		if tickCount >= 10 {
-			tickCount = 0
-			successCallback()
-		}
 	}
 }
diff --git a/util/systimemon/systime_mon_test.go b/util/systimemon/systime_mon_test.go
index f05098b63db7e..6964a9ac3d70d 100644
--- a/util/systimemon/systime_mon_test.go
+++ b/util/systimemon/systime_mon_test.go
@@ -35,7 +35,7 @@ func TestSystimeMonitor(t *testing.T) {
 			return time.Now().Add(-2 * time.Second)
 		}, func() {
 			errTriggered.Store(true)
-		}, func() {})
+		})
 
 	require.Eventually(t, errTriggered.Load, time.Second, 10*time.Millisecond)
 }