From 88e96ebca7112fcb998900a23f72b1d7e7bc04d3 Mon Sep 17 00:00:00 2001 From: Chen Lixiang Date: Mon, 11 Nov 2019 19:15:33 +0800 Subject: [PATCH] expression: implement vectorized evaluation for `builtinYearWeekWithModeSig` (#13328) --- expression/builtin_time_vec.go | 49 +++++++++++++++++++++++++++-- expression/builtin_time_vec_test.go | 1 + 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/expression/builtin_time_vec.go b/expression/builtin_time_vec.go index 23b8bc7fa4008..4a53c1b7ef7fe 100644 --- a/expression/builtin_time_vec.go +++ b/expression/builtin_time_vec.go @@ -1682,11 +1682,56 @@ func (b *builtinSubDateDurationIntSig) vecEvalDuration(input *chunk.Chunk, resul } func (b *builtinYearWeekWithModeSig) vectorized() bool { - return false + return true } +// vecEvalInt evals YEARWEEK(date,mode). +// See https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_yearweek func (b *builtinYearWeekWithModeSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error { - return errors.Errorf("not implemented") + n := input.NumRows() + buf1, err := b.bufAllocator.get(types.ETDatetime, n) + if err != nil { + return err + } + if err := b.args[0].VecEvalTime(b.ctx, input, buf1); err != nil { + return err + } + buf2, err := b.bufAllocator.get(types.ETInt, n) + if err != nil { + return err + } + if err := b.args[1].VecEvalInt(b.ctx, input, buf2); err != nil { + return err + } + + result.ResizeInt64(n, false) + result.MergeNulls(buf1) + i64s := result.Int64s() + ds := buf1.Times() + ms := buf2.Int64s() + for i := 0; i < n; i++ { + if result.IsNull(i) { + continue + } + date := ds[i] + if date.IsZero() { + if err := handleInvalidTimeError(b.ctx, types.ErrIncorrectDatetimeValue.GenWithStackByArgs(date.String())); err != nil { + return err + } + result.SetNull(i, true) + continue + } + mode := int(ms[i]) + if buf2.IsNull(i) { + mode = 0 + } + year, week := date.Time.YearWeek(mode) + i64s[i] = int64(week + year*100) + if i64s[i] < 0 { + i64s[i] = int64(math.MaxUint32) + } + } + return nil } func (b *builtinTimestampDiffSig) vectorized() bool { diff --git a/expression/builtin_time_vec_test.go b/expression/builtin_time_vec_test.go index 5f25d77204452..8f981d15a9233 100644 --- a/expression/builtin_time_vec_test.go +++ b/expression/builtin_time_vec_test.go @@ -183,6 +183,7 @@ var vecBuiltinTimeCases = map[string][]vecExprBenchCase{ }, ast.YearWeek: { {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDatetime}}, + {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDatetime, types.ETInt}}, }, ast.WeekOfYear: { {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDatetime}},