From 626fd5e45692cd8ad94391a8b6526e4d6a3ca4b0 Mon Sep 17 00:00:00 2001 From: Yiding Cui Date: Thu, 23 Nov 2023 15:36:17 +0800 Subject: [PATCH] address comments --- pkg/planner/core/rule_column_pruning.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/planner/core/rule_column_pruning.go b/pkg/planner/core/rule_column_pruning.go index c0e161026a910..d2e0a8406a79a 100644 --- a/pkg/planner/core/rule_column_pruning.go +++ b/pkg/planner/core/rule_column_pruning.go @@ -18,6 +18,7 @@ import ( "bytes" "context" "fmt" + "slices" "github.com/pingcap/tidb/pkg/expression" "github.com/pingcap/tidb/pkg/expression/aggregation" @@ -290,7 +291,7 @@ func (p *LogicalUnionAll) PruneColumns(parentUsedCols []*expression.Column, opt for i := len(used) - 1; i >= 0; i-- { if !used[i] { prunedColumns = append(prunedColumns, p.schema.Columns[i]) - p.schema.Columns = append(p.schema.Columns[:i], p.schema.Columns[i+1:]...) + p.schema.Columns = slices.Delete(p.schema.Columns, i, i) } } appendColumnPruneTraceStep(p, prunedColumns, opt)