Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial support for tiproxy [1/2] #4711

Merged
merged 4 commits into from
Sep 26, 2022
Merged

initial support for tiproxy [1/2] #4711

merged 4 commits into from
Sep 26, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Sep 19, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

What is changed and how does it work?

  1. remove /tools, /hack/tools and /vendor. All go tools are installed by GOBIN=$OUTPUT_BIN go install.
  2. github CI will use go version specified in go.mod
  3. there are some conflicts that needs to be processed manually in pkg/apis, pkg/client if you are actually using go 1.18 or above. Checks are supported locally by modifying hack/boilerplate/boilerplate.py or so. But CI go version is still 1.16, posting files generated by 1.18 or above will fail.
  4. add cache for github actions

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

hack/lib.sh Outdated Show resolved Hide resolved
@KanShiori KanShiori changed the title initial support for tiproxy [1/2] [DNM] initial support for tiproxy [1/2] Sep 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #4711 (a26db6b) into master (5e8dfff) will increase coverage by 9.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4711      +/-   ##
==========================================
+ Coverage   61.56%   70.58%   +9.02%     
==========================================
  Files         206      210       +4     
  Lines       22750    25492    +2742     
==========================================
+ Hits        14005    17993    +3988     
+ Misses       7444     6164    -1280     
- Partials     1301     1335      +34     
Flag Coverage Δ
e2e 54.67% <ø> (?)
unittest 61.56% <ø> (+<0.01%) ⬆️

@KanShiori KanShiori changed the title [DNM] initial support for tiproxy [1/2] initial support for tiproxy [1/2] Sep 22, 2022
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-tikv-scale-simultaneously

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 927e8d0

@xhebox
Copy link
Contributor Author

xhebox commented Sep 23, 2022

/test pull-e2e-kind

@xhebox
Copy link
Contributor Author

xhebox commented Sep 24, 2022

/test pull-e2e-kind

2 similar comments
@xhebox
Copy link
Contributor Author

xhebox commented Sep 24, 2022

/test pull-e2e-kind

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind

@ti-chi-bot
Copy link
Member

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-tngm
/test pull-e2e-kind-across-kubernetes

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-across-kubernetes

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-across-serial

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-across-serial

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-tngm
/test pull-e2e-kind-serial

@xhebox
Copy link
Contributor Author

xhebox commented Sep 26, 2022

/test pull-e2e-kind-serial

@ti-chi-bot ti-chi-bot merged commit 35f941e into pingcap:master Sep 26, 2022
@xhebox xhebox deleted the CI branch September 27, 2022 03:25
@xhebox xhebox mentioned this pull request Sep 28, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants