-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial support for tiproxy [1/2] #4711
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4711 +/- ##
==========================================
+ Coverage 61.56% 70.58% +9.02%
==========================================
Files 206 210 +4
Lines 22750 25492 +2742
==========================================
+ Hits 14005 17993 +3988
+ Misses 7444 6164 -1280
- Partials 1301 1335 +34
|
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
/test pull-e2e-kind |
/test pull-e2e-kind-br |
/test pull-e2e-kind-tikv-scale-simultaneously |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 927e8d0
|
/test pull-e2e-kind |
/test pull-e2e-kind |
2 similar comments
/test pull-e2e-kind |
/test pull-e2e-kind |
@xhebox: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test pull-e2e-kind-tngm |
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-across-serial |
/test pull-e2e-kind-tngm |
/test pull-e2e-kind-serial |
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
What is changed and how does it work?
/tools
,/hack/tools
and/vendor
. All go tools are installed byGOBIN=$OUTPUT_BIN go install
.go.mod
pkg/apis
,pkg/client
if you are actually using go 1.18 or above. Checks are supported locally by modifyinghack/boilerplate/boilerplate.py
or so. But CI go version is still1.16
, posting files generated by1.18
or above will fail.Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.