This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
kv: fix handling of column default values #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if the column is AUTO_INCREMENT, fill in with row_id (assume it is missing for the entire table instead of just a few values) * if the column has DEFAULT, fill in that value
kennytm
added
status/PTAL
|
/run-all-tests |
|
LGTM |
IANTHEREAL
added
status/LGT1
csuzhangxc
reviewed
Apr 24, 2019
| } else { | ||
| value, err = table.GetColOriginDefaultValue(kvcodec.se, col.ToInfo()) | ||
| value, err = table.GetColDefaultValue(kvcodec.se, col.ToInfo()) |
There was a problem hiding this comment.
not handle some cases like current_timestamp anymore?
There was a problem hiding this comment.
CURRENT_TIMESTAMP does work, it currently fetches the actual current time 🤔. (Before this PR it was always NULL.) Gonna change to a fixed timestamp stored in the checkpoint to ensure determinism in a future PR.
|
/run-all-tests tidb=master tikv=master pd=master |
csuzhangxc
added
status/LGT2
kennytm
added
the
Should Cherry-pick
kennytm
added a commit
that referenced
this pull request
Apr 27, 2019
* kv: fix handling of column default values * if the column is AUTO_INCREMENT, fill in with row_id (assume it is missing for the entire table instead of just a few values) * if the column has DEFAULT, fill in that value * tests: ensure DEFAULT CURRENT_TIMESTAMP works
kennytm
removed
the
Should Cherry-pick
IANTHEREAL
pushed a commit
that referenced
this pull request
Apr 28, 2019
* kv: fix handling of column default values (#170) * kv: fix handling of column default values * if the column is AUTO_INCREMENT, fill in with row_id (assume it is missing for the entire table instead of just a few values) * if the column has DEFAULT, fill in that value * tests: ensure DEFAULT CURRENT_TIMESTAMP works * tests,restore: re-enable the exotic_filenames test (#172)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Properly fill in the default value for a missing column.
What is changed and how it works?
Check List
Tests
Side effects
Related changes