This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Cherry-pick 2.1: Fix interpretation of integers in a BIT column (#161) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tests: fix existing test failure * mydump: fixed conversion of integers into bits We need to create a special branch for integers, since casting 123 and '123' into BIT type behave differently. Also fixed handling of 0x/0b bit strings since Ragel doesn't recognize '+' in a regex -_-. * mydump: store description of `token` in an array instead of switch cases * tests: test behavior of integers for ENUM and SET types as well
kennytm
added
2.1-cherry-pick
|
/run-all-tests tidb=release-2.1 pd=release-2.1 tikv=release-2.1 |
|
PTAL @GregoryIan @lonng |
|
do we need code? |
|
LGTM |
|
@GregoryIan No, that specific line was added to fix breakage introduced in #157, but was not backported to 2.x. |
kennytm
added
status/LGT1
|
LGTM |
IANTHEREAL
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-picks #161 to 2.1 for 2.1.9 release.
What is changed and how it works?
Check List
Tests
Side effects
Related changes