Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It might be better to open 'Go's download page' link in a new tab. #81

Open
sunxiaoguang opened this issue Aug 16, 2021 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@sunxiaoguang
Copy link
Collaborator

image

It might be better to open 'Go's download page' link in a new tab as we really just want to download go at background and keep reading the book.

@tisonkun
Copy link
Contributor

Make sense. I'll create a pull request. May we just replace the default []() syntax with <a target="_blank">...</a>

@tisonkun
Copy link
Contributor

@sunxiaoguang @siddontang we can use target="_blank" to implement it here.

But I'm thinking of whether or not we apply/evaluate this rule to all links. Since in Safari or Chrome we can easily open a link in new tab by Cmd + Shift + Click [1], I tend to leave the function to the browser than pollute raw html here.

[1] https://support.google.com/chromebook/thread/685410/how-do-i-set-the-default-on-open-in-a-new-tab-to-automatically-switch-to-that-tab?hl=en

@sunxiaoguang
Copy link
Collaborator Author

I think only a few of them worth opening in new tab. Most can remain the same.

@tisonkun
Copy link
Contributor

I think only a few of them worth opening in new tab. Most can remain the same.

so what's your opinion on links worth opening in new tab by default? I'm confused since in this page all links looks reasonable to be opened in a new tab.

@tisonkun
Copy link
Contributor

If the browser can do you a favor, I'd prefer leave the choice to the user. How to open a link is always under control of the user.

@tisonkun tisonkun added the enhancement New feature or request label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants