Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more time field for slow query detail page #810

Merged
merged 32 commits into from
Nov 26, 2020

Conversation

crazycs520
Copy link
Collaborator

@crazycs520 crazycs520 commented Nov 24, 2020

Signed-off-by: crazycs520 crazycs520@gmail.com

image

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@breezewish
Copy link
Member

breezewish commented Nov 24, 2020

Cool! How about making some idents to let user better know their relationship?

BTW please also test against latest 4.0 branch to make sure everything works (not just master branch).

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baurine
Copy link
Collaborator

baurine commented Nov 25, 2020

Cool! How about making some idents to let user better know their relationship?

Do you mean issue #809 ? I can do that later.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@breezewish
Copy link
Member

Would you like to carry this in 4.0.9, or along with #809 and carry it in 4.0.10?

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Collaborator Author

Would you like to carry this in 4.0.9, or along with #809 and carry it in 4.0.10?

Sure, Done.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
wait_ts:   Wait Txn StartTS Time
wait_ts_tooltip: Time consumed of waiting transaction start ts
cop_time:   Coprocessor request Time
cop_time_tooltip: Time consumed of TiDB sending cop request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a total time or P99 time or AVG time? As we know that there can be multiple Copr requests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time model is below:

start := time.Now()

for _, cop := range tasks {
    go sendAndRecvCopRequestResult();
} 
waitCopRequestFinish()

cop_time := time.Since(start)    // This is the cop_time.

ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
crazycs520 and others added 9 commits November 26, 2020 14:21
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
crazycs520 and others added 5 commits November 26, 2020 14:37
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Co-authored-by: Wenxuan <hi@breeswish.org>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/zh.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
ui/lib/apps/SlowQuery/translations/en.yaml Outdated Show resolved Hide resolved
@breezewish breezewish merged commit 6bde0ac into pingcap:master Nov 26, 2020
breezewish pushed a commit that referenced this pull request Nov 26, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants