Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support common name check for tls(#934) #937

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

cherry-pick #934

What problem does this PR solve?

fix issue #930
Allow pump and drainer add TLS certificate CN validation

What is changed and how it works?

add VerifyPeerCertificate function for tls

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

2 similar comments
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

@july2993 @kennytm PTAL

@july2993
Copy link
Contributor

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit a5b65c5 into release-3.0 Mar 20, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/pick_cn_check branch March 20, 2020 06:27
@sre-bot
Copy link

sre-bot commented Mar 20, 2020

cherry pick to release-3.1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants