drainer: fix failure to update BIT columns with downstream TiDB #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
july2993
reviewed
Jul 1, 2019
july2993
approved these changes
Jul 1, 2019
kennytm
added a commit
that referenced
this pull request
Jul 1, 2019
july2993
pushed a commit
that referenced
this pull request
Jul 2, 2019
This was referenced Dec 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue TOOL-1346, which is caused by pingcap/tidb#10988.
What is changed and how it works?
Encode BIT types as integers instead of byte strings. Since the longest value is BIT(64), it is safe to always convert as
uint64.Check List
Tests
Code changes
Side effects
Related changes