Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit gc speed #620

Merged
merged 8 commits into from
May 24, 2019
Merged

limit gc speed #620

merged 8 commits into from
May 24, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented May 24, 2019 •
edited
Loading

What problem does this PR solve?

limit gc rate to avoid affect normal write.
update goleveldb for:

What is changed and how it works?

stop delete data when L0 file number reach the condition need to compact

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

IANTHEREAL
IANTHEREAL reviewed May 24, 2019
View reviewed changes
pump/storage/storage.go Outdated Show resolved Hide resolved
IANTHEREAL
IANTHEREAL reviewed May 24, 2019
View reviewed changes
pump/storage/storage.go Outdated
time.Sleep(5 * time.Second)
continue
}
if stats.LevelTablesCounts[0] >= l0Trigger {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output log

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add in a82e66f

@IANTHEREAL
Copy link
Collaborator

Rest LGTM

@july2993
Copy link
Contributor Author

/run-all-tests

IANTHEREAL
IANTHEREAL previously approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

/run-all-tests

@july2993
Copy link
Contributor Author

/run-all-tests

IANTHEREAL
IANTHEREAL approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@IANTHEREAL IANTHEREAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit dff0701 into pingcap:release-2.1 May 24, 2019
july2993 added a commit to july2993/tidb-binlog that referenced this pull request Jun 3, 2019
@july2993
limit gc speed (pingcap#620)
97fbd4b
july2993 added a commit to july2993/tidb-binlog that referenced this pull request Jun 3, 2019
@july2993
limit gc speed (pingcap#620)
3220893
@july2993 july2993 mentioned this pull request Jun 3, 2019
Merged
july2993 added a commit that referenced this pull request Jun 3, 2019
@july2993
limit gc speed (#620) (#628)
3e11ff1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@july2993 @IANTHEREAL