Support update pump or drainer status #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support update pump or drainer status
aliiohs
changed the title
…ate_Pump_or_Drainer_status_2019_3_14
|
LGTM |
|
@kennytm PTAL |
kennytm
reviewed
Mar 14, 2019
ast/misc.go
Outdated
|
|
||
| // Restore implements Node interface. | ||
| func (n *ChangeStmt) Restore(ctx *RestoreCtx) error { | ||
| ctx.WriteKeyWord(fmt.Sprintf("CHANGE %s TO", strings.ToUpper(n.NodeType))) |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord(fmt.Sprintf("CHANGE %s TO", strings.ToUpper(n.NodeType))) | |
| ctx.WriteKeyWord("CHANGE ") | |
| ctx.WriteKeyWord(n.NodeType) | |
| ctx.WriteKeyWord(" TO ") |
ast/misc.go
Outdated
| type ChangeStmt struct { | ||
| stmtNode | ||
|
|
||
| NodeType string |
There was a problem hiding this comment.
Should we use an enum for this?
There was a problem hiding this comment.
i already changed, but i need you confirm it.
kennytm
reviewed
Mar 18, 2019
ast/misc.go
Outdated
|
|
||
| // Restore implements Node interface. | ||
| func (n *ChangeStmt) Restore(ctx *RestoreCtx) error { | ||
| ctx.WriteKeyWord("CHANGE") |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord("CHANGE") | |
| ctx.WriteKeyWord("CHANGE ") |
ast/misc.go
Outdated
| // Restore implements Node interface. | ||
| func (n *ChangeStmt) Restore(ctx *RestoreCtx) error { | ||
| ctx.WriteKeyWord("CHANGE") | ||
| ctx.WriteKeyWord(strings.ToUpper(n.NodeType)) |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord(strings.ToUpper(n.NodeType)) | |
| ctx.WriteKeyWord(n.NodeType) |
ast/misc.go
Outdated
| func (n *ChangeStmt) Restore(ctx *RestoreCtx) error { | ||
| ctx.WriteKeyWord("CHANGE") | ||
| ctx.WriteKeyWord(strings.ToUpper(n.NodeType)) | ||
| ctx.WriteKeyWord("TO") |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord("TO") | |
| ctx.WriteKeyWord(" TO NODE_STATE ") |
And delete the next line
ast/misc.go
Outdated
| ctx.WriteKeyWord("NODE_STATE") | ||
| ctx.WritePlain("=") | ||
| ctx.WriteString(n.State) | ||
| ctx.WriteKeyWord("FOR") |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord("FOR") | |
| ctx.WriteKeyWord(" FOR NODE_ID ") |
And delete the next line
# Conflicts: # parser.y
…_3_14 # Conflicts: # parser.go
…_3_14 # Conflicts: # parser.go
# Conflicts: # parser.y
…ate_Pump_or_Drainer_status_2019_3_14 # Conflicts: # parser.y
WangXiangUSTC
approved these changes
Mar 18, 2019
WangXiangUSTC
pushed a commit
to WangXiangUSTC/parser
that referenced
this pull request
Mar 25, 2019
WangXiangUSTC
added a commit
that referenced
this pull request
Mar 26, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support_update_Pump_or_Drainer_status
proposal：pingcap/tidb#9201
What is changed and how it works?
it will change parser.y/parser.go/ast.misc.go /misc.go.
Check List
Tests
Code changes
Side effects
Related changes