-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding vitess_hash function to ast #1089
Conversation
Build is failing because master is red. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Reminiscent, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack). |
@kennytm Please help merge the PR. Thanks! |
PTAL @wjhuang2016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests for "vitess_hash" in parser_test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
What problem does this PR solve?
Issue Number: pingcap/tidb#20971
Problem Summary: Implementing vitess_hash function to support efficient migration between tidb <-> vitess.
What is changed and how it works?
Proposal: pingcap/tidb#20971
What's Changed: New builtin_misc function added implementing vitess_hash algorithm.
Related changes
In order PRs need to be merged:
Release note
Added vitess_hash function which implements Vitess' hashing algorithm to determine sharding key.