Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vitess_hash function to ast #1089

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Conversation

bezmax
Copy link
Contributor

@bezmax bezmax commented Nov 11, 2020

What problem does this PR solve?

Issue Number: pingcap/tidb#20971

Problem Summary: Implementing vitess_hash function to support efficient migration between tidb <-> vitess.

What is changed and how it works?

Proposal: pingcap/tidb#20971

What's Changed: New builtin_misc function added implementing vitess_hash algorithm.

Related changes

In order PRs need to be merged:

  1. Adding vitess_hash function code to tipb tipb#198
  2. (This PR) Adding vitess_hash function to ast #1089
  3. expression: Implementation of Vitess hashing algorithm. tidb#23493

Release note

Added vitess_hash function which implements Vitess' hashing algorithm to determine sharding key.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2020

CLA assistant check
All committers have signed the CLA.

@bezmax bezmax changed the title Draft: Adding vitess_hash function to ast Adding vitess_hash function to ast Nov 12, 2020
@bezmax
Copy link
Contributor Author

bezmax commented Nov 12, 2020

Build is failing because master is red.

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Nov 13, 2020
Copy link

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@Reminiscent, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack).

@Reminiscent
Copy link

@kennytm Please help merge the PR. Thanks!

@kennytm
Copy link
Contributor

kennytm commented Nov 25, 2020

PTAL @wjhuang2016

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for "vitess_hash" in parser_test?

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Dec 1, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Dec 1, 2020
@kennytm kennytm merged commit 73dd7e6 into pingcap:master Dec 1, 2020
@bezmax bezmax deleted the bezmax-vitess-hash branch March 17, 2021 17:00
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants