Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] wrong dates of the chart of star increment #1404

Closed
TommyLemon opened this issue Mar 16, 2023 · 1 comment · Fixed by #1408
Closed

[Bug] wrong dates of the chart of star increment #1404

TommyLemon opened this issue Mar 16, 2023 · 1 comment · Fixed by #1408
Labels
type/bug Bug issues

Comments

@TommyLemon
Copy link

TommyLemon commented Mar 16, 2023

Bug Report

Describe the bug

from the second last day, the dates are all 1 day ahead of the actual dates.

missing "Mar 15", the "Mar 14" is wrong, actually the increased stars belongs to "Mar 15"

https://ossinsight.io/analyze/Tencent/APIJSON
image
image

https://ossinsight.io/analyze/glennliao/apijson-go#overview
image
image

To Reproduce
Steps to reproduce the behavior:
open the links above

Expected behavior

fix the wrong dates

Screenshots

image

image

image

image

Desktop (please complete the following information):

  • OS: macOS 13.0 (22A8380)
  • Browser Chrome
  • Version 109.0.5414.119 (Official Build) (arm64)

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@TommyLemon TommyLemon added the type/bug Bug issues label Mar 16, 2023
@TommyLemon TommyLemon changed the title [Bug] wrong dates of the chart of start increasing [Bug] wrong dates of the chart of start increment Mar 16, 2023
@codestafa
Copy link

Looks like this has something to do with current_period_day

in Bars.tsx, printing data.data?.data after line 38 shows this for the Stars graph:

[
  {
    "current_period_day": "2023-03-19T00:00:00.000Z",
    "current_period_day_stars": 745,
    "current_period_stars": 16572,
    "idx": 1,
    "last_period_day": "2023-02-19T00:00:00.000Z",
    "last_period_day_stars": 446,
    "last_period_stars": 11216
  },
  {
    "current_period_day": "2023-03-17T00:00:00.000Z",
    "current_period_day_stars": 533,
    "current_period_stars": 16572,
    "idx": 2,
    "last_period_day": "2023-02-17T00:00:00.000Z",
    "last_period_day_stars": 343,
    "last_period_stars": 11216
  },
  {
    "current_period_day": "2023-03-16T00:00:00.000Z",
    "current_period_day_stars": 614,
    "current_period_stars": 16572,
    "idx": 3,
    "last_period_day": "2023-02-16T00:00:00.000Z",
    "last_period_day_stars": 480,
    "last_period_stars": 11216
  },
  {
    "current_period_day": "2023-03-15T00:00:00.000Z",
    "current_period_day_stars": 582,
    "current_period_stars": 16572,
    "idx": 4,
    "last_period_day": "2023-02-15T00:00:00.000Z",
    "last_period_day_stars": 590,
    "last_period_stars": 11216
  },
  {
    "current_period_day": "2023-03-14T00:00:00.000Z",
    "current_period_day_stars": 583,
    "current_period_stars": 16572,
    "idx": 5,
    "last_period_day": "2023-02-14T00:00:00.000Z",
    "last_period_day_stars": 712,
    "last_period_stars": 11216
  },
  ...
  ...
  ...
  ...
]

As you can see, the most recent day is today (2023-03-19T00:00:00.000Z), but it skips 2023-03-18T00:00:00.000Z and goes directly to 2023-03-17T00:00:00.000Z

@TommyLemon TommyLemon changed the title [Bug] wrong dates of the chart of start increment [Bug] wrong dates of the chart of star increment Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants