This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
use cobra to simplify command flags #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI was broken |
siddontang
force-pushed
the
siddontang/flags
branch
from
cb71d4b to
13babac
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 58.33% 58.33%
=======================================
Files 13 13
Lines 732 732
=======================================
Hits 427 427
Misses 265 265
Partials 40 40 |
tangenta
approved these changes
Feb 29, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous flags handling is ugly, and we can use cobra to simplify them.