This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
support both filesize and rows arguments #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mightyguava
reviewed
Nov 2, 2020
v4/export/writer.go
Outdated
| DB: ir.DatabaseName(), | ||
| Table: ir.TableName(), | ||
| } | ||
| if bothEnabled { | ||
| o.id = 0 | ||
| o.idFormat = fmt.Sprintf("%09d", ir.ChunkIndex()) + "%04d" |
There was a problem hiding this comment.
13 digits will overflow an int32. Do tools that read these files parse out the number, or just rely on it for filesystem ordering?
There was a problem hiding this comment.
so far all of myloader, Lightning and DM only rely on filesystem order, and won't parse the number. Lightning is the only one requiring that part to be [0-9]+ because the regex was written too tightly.
| @@ -117,7 +117,7 @@ func (s *testDumpSuite) TestWriteTableData(c *C) { | |||
| err = writer.WriteTableData(ctx, tableIR) | |||
| c.Assert(err, IsNil) | |||
|
|
|||
| p := path.Join(dir, "test.employee.0.sql") | |||
| p := path.Join(dir, "test.employee.000000000.sql") | |||
There was a problem hiding this comment.
Should there be a test that uses the 13 digit number?
There was a problem hiding this comment.
Added in ffcea13. The integration test in rows will also help check this.
kennytm
reviewed
Nov 7, 2020
lichunzhu
force-pushed
the
supportBothFilesizeAndRows
branch
from
5c4ed1d
to
7361034
Compare
kennytm
previously approved these changes
Nov 9, 2020
Yes. I have revised |
kennytm
approved these changes
Nov 9, 2020
|
(trigger CI) |
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support both filesize and rows arguments * fix bash * add unit test for the situation that both filesize and rows are enabled * address comment * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support both filesize and rows arguments * fix bash * add unit test for the situation that both filesize and rows are enabled * address comment * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support both filesize and rows arguments * fix bash * add unit test for the situation that both filesize and rows are enabled * address comment * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* support both filesize and rows arguments * fix bash * add unit test for the situation that both filesize and rows are enabled * address comment * address comment
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* support both filesize and rows arguments * fix bash * add unit test for the situation that both filesize and rows are enabled * address comment * address comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #164
What is changed and how it works?
Support configuring both
-Fand-rarguments.When specifying
-For-rargument, the dumped SQL format is${db}.${table}.%09d.sql.When specifying both
-Fand-rarguments, the dumped SQL format is${db}.${table}.%09d%04d.sql.Check List
Tests
Related changes
Release note
-Fand-rarguments at the same time.