This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 52.19% 50.75% -1.44%
==========================================
Files 17 17
Lines 1868 1909 +41
==========================================
- Hits 975 969 -6
- Misses 825 868 +43
- Partials 68 72 +4 |
…hu/dumpling into optimizeMySQLConsistency
kennytm
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* refine conn pool
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* refine conn pool
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* refine conn pool
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
* refine conn pool
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
* refine conn pool
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #118
--threads
argument can't control concurrently dumping tables.ResolveAutoConsistency
inadjustConfig
will lead consistency tonone
becauseserverType
is not got yet.What is changed and how it works?
rateLimit
toconnectionsPool
to control database connections like mydumper.Start
forTableIR
.concurrentDumpTable
will return an array of not started TableIRs.ResolveAutoConsistency
after detect ServerType.Check List
Tests
Side effects
Related changes
Release note
FTWRL
after connections are created to reduce lock time for mysql.